Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ready for review] switch config updated with optional ssh port #1179

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexhbot
Copy link
Contributor

@alexhbot alexhbot commented Aug 23, 2022

Related PRs / Issues

Added an option to include an SSH port into the switch model by specifying an argument.

UI / API Impact

Additional work is needed to be able to pass SSH argument from user level to the switch config file.

Verilog / AGFI Compatibility

NA

Contributor Checklist

  • Is this PR's title suitable for inclusion in the changelog and have you added a changelog:<topic> label?
  • Did you add Scaladoc/docstring/doxygen to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous prints/debugging code?
  • Did you state the UI / API impact?
  • Did you specify the Verilog / AGFI compatibility impact?
  • If applicable, did you regenerate and publicly share default AGFIs?
  • If applicable, did you apply the ci:fpga-deploy label?
  • If applicable, did you apply the Please Backport label?

Reviewer Checklist (only modified by reviewer)

Note: to run CI on PRs from forks, comment @Mergifyio copy main and manage the change from the new PR.

  • Is the title suitable for inclusion in the changelog and does the PR have a changelog:<topic> label?
  • Did you mark the proper release milestone?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@alexhbot alexhbot changed the title switch config update start [WIP] switch config update start Aug 23, 2022
@alexhbot alexhbot requested a review from sagark August 23, 2022 20:32
@alexhbot alexhbot marked this pull request as draft August 23, 2022 20:32
@alexhbot alexhbot force-pushed the alexhao-switch-config-ssh-support branch 2 times, most recently from 44f662d to aa200b7 Compare August 23, 2022 21:48
@alexhbot alexhbot force-pushed the alexhao-switch-config-ssh-support branch from aa200b7 to 8d9c72f Compare August 23, 2022 21:50
@alexhbot alexhbot changed the title [WIP] switch config update start [Ready for review] switch config updated with optional ssh port Aug 23, 2022
@alexhbot alexhbot added the changelog:added Put PR title in 'Added' section of changelog label Aug 23, 2022
@alexhbot alexhbot marked this pull request as ready for review August 23, 2022 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:added Put PR title in 'Added' section of changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant