New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make diff snapshots transactional #4580
Make diff snapshots transactional #4580
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4580 +/- ##
=======================================
Coverage 82.13% 82.14%
=======================================
Files 255 255
Lines 31267 31283 +16
=======================================
+ Hits 25682 25698 +16
Misses 5585 5585
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
tests/integration_tests/functional/test_snapshot_not_losing_dirty_pages.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_snapshot_not_losing_dirty_pages.py
Outdated
Show resolved
Hide resolved
tests/integration_tests/functional/test_snapshot_not_losing_dirty_pages.py
Outdated
Show resolved
Hide resolved
5bf4f93
to
cd0eb6b
Compare
tests/integration_tests/functional/test_snapshot_not_losing_dirty_pages.py
Outdated
Show resolved
Hide resolved
f489f87
to
c49fc4e
Compare
Store kvm dirty bitmap inside firecrackers internal bitmap so no data is lost incase of an error Signed-off-by: Jack Thomson <jackabt@amazon.com> Co-authored-by: Roman Kovtyukh <HelloDearGrandma@gmail.com> Co-authored-by: Pablo Barbáchano <pablob@amazon.com>
0ddeac8
to
f497630
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, looks good to me. As Patrick said maybe squash the last two commits and maybe consider using psutil instead of df, but other than that looks good to me.
tests/integration_tests/functional/test_snapshot_not_losing_dirty_pages.py
Outdated
Show resolved
Hide resolved
f497630
to
963448b
Compare
Only if the snapshot writing fails then store the kvm buffer inside the firecracker internal bitmap. Also attempted to make the filling algorithm in the test to be dynamic so it will work on ARM chips Signed-off-by: Jack Thomson <jackabt@amazon.com>
963448b
to
76b7bc5
Compare
Store kvm dirty bitmap inside firecrackers internal bitmap so no data is lost incase of an error
Changes
As we load the KVM bitmap store it inside the internal firecracker bitmap. This is done incase of a failure while creating the snapshot, as the data is stored until it's completed successfully.
Reason
Making snapshot transactional
Ticket here: #4545
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md
.PR Checklist
PR.
CHANGELOG.md
.TODO
s link to an issue.contribution quality standards.
rust-vmm
.