feat: add call gemini for v2 #1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhuleatt
reviewed
Apr 29, 2024
Comment on lines
+21
to
+24
| const geminiToken = defineSecret("API_TOKEN", { | ||
| description: "Gemini API token. Created using " + | ||
| "https://ai.google.dev/tutorials/get_started_node#set-up-project", | ||
| }); |
There was a problem hiding this comment.
this is great! thanks for adding a descriptive prompt.
Comment on lines
+26
to
+27
| exports.callGemini = onCall({secrets: [geminiToken]}, async (request) => { | ||
|
|
There was a problem hiding this comment.
Before calling Gemini, let's look for both appcheck and auth, but gate each with its own boolean parameter (https://firebase.google.com/docs/functions/config-env?gen=2nd#parameter_types) so devs can choose whether they want auth/app check or not.
Something like:
// ...imports
const appCheckRequired = defineBoolean("APP_CHECK_REQUIRED");
const authRequired = defineBoolean("AUTH_REQUIRED");
// ...other setup
exports.callGemini = onCall(
{
enforceAppCheck: appCheckRequired, // Reject requests with missing or invalid App Check tokens.
},
(request) => {
if (authRequired.val() && !request.auth) {
throw new HttpsError(
"failed-precondition",
"The function must be called while authenticated.",
);
}
// ...call Gemini
},
);
Comment on lines
+28
to
+30
| }, | ||
| "dependencies": { | ||
| "firebase": "^10.11.1" |
There was a problem hiding this comment.
I think this was an accident. Might mean root-level package-lock.json update was too.
| @@ -15,3 +15,4 @@ | |||
| packages: | |||
| - 'Node/**' | |||
| - 'Node-1st-gen/**' | |||
| - "!Node-1st-gen/image-maker/**" | |||
There was a problem hiding this comment.
please remove before merging
| "@google/generative-ai": "^0.5.0", | ||
| "firebase-admin": "^11.9.0", | ||
| "firebase-functions": "^4.4.1", | ||
| "node-fetch": "^2.6.7" |
There was a problem hiding this comment.
is node-fetch needed for this sample?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.