Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_admob] feat: support adaptive banner for admob #2619

Closed
wants to merge 1 commit into from

Conversation

uny
Copy link

@uny uny commented May 24, 2020

Description

Support admob adaptive banner.
https://developers.google.com/admob/ios/banner/adaptive
https://developers.google.com/admob/android/banner/adaptive

Related Issues

#2003

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@uny uny force-pushed the feature/adaptive-banner branch 3 times, most recently from 5a1b2f7 to 8ea0d19 Compare May 24, 2020 08:52
Signed-off-by: Yuki Nagai <unynagai@gmail.com>
@uny uny force-pushed the feature/adaptive-banner branch from 8ea0d19 to fdc7228 Compare May 24, 2020 08:56
@marciorr
Copy link

marciorr commented Sep 5, 2020

It would be very nice to have adaptive banners. Any idea when it will be available?

@peterweb2005
Copy link

better have an example on how to apply the "quickstart"

https://developers.google.com/admob/android/banner/adaptive#quickstart

@ycv005
Copy link

ycv005 commented Jan 31, 2021

@amirh @bparrishMines please have a look at this pr by @uny .

@ycv005
Copy link

ycv005 commented Jan 31, 2021

@uny WIll you tell, how to use it. I have copied your code but unable to figure out how to use it or start with it. Thanks in advance.

@bparrishMines
Copy link
Contributor

@uny @ycv005 Our team is unable to look at this as we are currently focused on adding widget support for Ads and have started a closed beta: https://medium.com/flutter/new-ads-beta-inline-banner-and-native-support-for-the-flutter-mobile-ads-plugin-e48a7e9a0e64.

Feel free to follow flutter/flutter#12114. The work on the new Ads plugin will most likely lead to deprecating this one, so we are focusing on getting it to open beta where everyone can use the new plugin.

@russellwheatley
Copy link
Member

The firebase_admob plugin will be deprecated in April 2021 in favor of Google Mobile Ads SDK for Flutter.
Google Mobile Ads SDK for Flutter is a new Flutter plugin that supports more Ads formats than firebase_admob does. Google Mobile Ads SDK for Flutter currently supports loading and displaying banner, interstitial (full-screen), native ads, and rewarded video ads across AdMob and AdManager. It also supports displaying banner and native ads as Widgets as opposed to being overlayed over all app content.
We're now recommending projects currently using firebase_admob migrate to Google Mobile Ads SDK for Flutter following the instructions outlined here.
Issues with migrating or with using the new package should now be raised over on the Google Mobile Ads SDK for Flutter repository.

@firebase firebase locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants