New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(messaging): change usage of Platform.isIos
to defaultTargetPlatform
to allow mocking platform more easily
#12183
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Platform.isIos
to defaultTargetPlatform
to allow to mock platform more easily
Platform.isIos
to defaultTargetPlatform
to allow to mock platform more easilyPlatform.isIos
to defaultTargetPlatform
to allow mocking platform more easily
...g/firebase_messaging_platform_interface/lib/src/method_channel/method_channel_messaging.dart
Outdated
Show resolved
Hide resolved
…ace/lib/src/method_channel/method_channel_messaging.dart
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fachrifaul - You need to remove this import from the same file you changed: https://github.com/firebase/flutterfire/actions/runs/7626531820/job/20773125499?pr=12183#step:5:241
Done |
if (defaultTargetPlatform == TargetPlatform.iOS || | ||
defaultTargetPlatform == TargetPlatform.macOS) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
defaultTargetPlatform
doesn't care if the platform is running on web browser or not, it could be TargetPlatform.iOS
but on web browser, we need to handle this case as well
Description
Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.
Hard to mock Platform, need to change to
defaultTargetPlatform
Related Issues
Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]
).This will ensure a smooth and quick review process. Updating the
pubspec.yaml
and changelogs is not required.///
).melos run analyze
) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?