Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(auth): Removed redundant languageCode null-check. #12076

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Naveed-dev30
Copy link

@Naveed-dev30 Naveed-dev30 commented Dec 26, 2023

Description

` String? get languageCode {
if (_delegate.languageCode != null) {
return _delegate.languageCode;
}

return null;

}`

This code has a redundant check. Getter languageCode will always return String? for _delegate.languageCode. It is more easier to understand the simple and straight logic if is done as:

String? get languageCode { return _delegate.languageCode; }

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the [Contributor Guide] and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See [Contributor Guide]).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the [Flutter Style Guide].
  • I signed the [CLA].
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • [x ] No, this is not a breaking change.

Copy link

google-cla bot commented Dec 26, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Naveed-dev30 Naveed-dev30 changed the title Removed redundant language nullable check. refactor: Removed redundant language nullable check. Dec 26, 2023
@russellwheatley
Copy link
Member

hey @Naveed-dev30, if you sign the CLA, we can look to get this merged. Thanks 👍

@russellwheatley russellwheatley changed the title refactor: Removed redundant language nullable check. chore(auth): Removed redundant languageCode null-check. Jan 8, 2024
@Naveed-dev30
Copy link
Author

Hey @russellwheatley thanks for the reminder. I have signed. Kindly merge my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants