Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for demo project #11973

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

feat: add support for demo project #11973

wants to merge 10 commits into from

Conversation

Lyokone
Copy link
Contributor

@Lyokone Lyokone commented Dec 4, 2023

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

closes #9507

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@Lyokone Lyokone marked this pull request as ready for review January 5, 2024 07:42
@@ -141,6 +141,15 @@ flutterfire configure
flutter run
```

If you would rather use a demo project, you can start the Firebase Emulator and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a link to the docs for the emulator would be ideal
https://firebase.google.com/docs/emulator-suite

docs/setup/_setup_main.md Outdated Show resolved Hide resolved
@Lyokone
Copy link
Contributor Author

Lyokone commented Jan 5, 2024

hey @kevinthecheung, could you check this doc update? :)

@Lyokone
Copy link
Contributor Author

Lyokone commented Feb 9, 2024

Hey @kevinthecheung, do you have some time check this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[firebase_core] use with Firebase Emulator demo project.
3 participants