Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add additional site config information to hosting:sites:list #5087

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

bkendall
Copy link
Contributor

@bkendall bkendall commented Oct 7, 2022

Description

There's useful information in Hosting's API that we can present in the CLI - specifically if Cloud Logging is enabled or how many versions are retained. We should display that!

image

This is a tiny step towards addressing #215 which is ooollllddddd haha. But to be able to view this in the CLI would be good.

@codecov-commenter
Copy link

codecov-commenter commented Oct 7, 2022

Codecov Report

Base: 56.06% // Head: 56.07% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (1d73c9b) compared to base (8f18fba).
Patch coverage: 87.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5087      +/-   ##
==========================================
+ Coverage   56.06%   56.07%   +0.01%     
==========================================
  Files         307      307              
  Lines       20635    20643       +8     
  Branches     4166     4168       +2     
==========================================
+ Hits        11568    11575       +7     
  Misses       8066     8066              
- Partials     1001     1002       +1     
Impacted Files Coverage Δ
src/hosting/api.ts 82.50% <87.50%> (+0.26%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@bkendall bkendall removed the request for review from kmcnellis October 7, 2022 22:44
@bkendall bkendall marked this pull request as draft October 7, 2022 22:44
@EvanCesanek
Copy link

This is a great idea! Two suggestions/requests:

  1. Please include this information in the return value of firebase hosting:list:sites, rather than simply displaying it. This is important for using the CLI as a module.
  2. Please allow access to even more of the information available via the Hosting API. For instance, I'd love a command like firebase hosting:list:releases <siteId> that returns the output of apiClient.get(`/projects/${project}/sites/${site}/releases`). Alternatively, to avoid introducing another command, maybe return some key information about the current release for each site in firebase hosting:list:sites (e.g., message, releaseTime, version.status).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants