Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when WSL users don't have Java #1717

Merged
merged 5 commits into from Oct 11, 2019
Merged

Warn when WSL users don't have Java #1717

merged 5 commits into from Oct 11, 2019

Conversation

samtstern
Copy link
Contributor

Description

Fixes #1713

Scenarios Tested

WSL with no Java:

$ ../firebase-tools/lib/bin/firebase.js --project=fir-dumpster emulators:start --only firestore
i  Starting emulators: ["firestore"]
⚠  No Firestore rules file specified in firebase.json, using default rules.
i  firestore: Serving ALL traffic (including WebChannel) on http://localhost:8080
⚠  firestore: Support for WebChannel on a separate port (8081) is DEPRECATED and will go away soon. Please use port above instead.
⚠  firestore: Could not spawn child process for emulator, do you have java installed?
i  Shutting down emulators.

Sample Commands

N/A

@samtstern samtstern requested review from bkendall, yuchenshi and ryanpbrewster and removed request for bkendall October 11, 2019 19:10
@googlebot googlebot added the cla: yes Manual indication that this has passed CLA. label Oct 11, 2019
@coveralls
Copy link

coveralls commented Oct 11, 2019 •
edited

Coverage Status

Coverage decreased (-0.09%) to 65.119% when pulling ea1de64 on ss-wsl-no-java into 3368790 on master.

yuchenshi
yuchenshi approved these changes Oct 11, 2019
View reviewed changes
src/serve/javaEmulators.ts Outdated Show resolved Hide resolved
@samtstern samtstern merged commit 45a9a8b into master Oct 11, 2019
Elgarni added a commit to Elgarni/firebase-tools that referenced this pull request Oct 26, 2019
@Elgarni
Merge branch 'master' into check-permissions-on-feature-init
1b20ff2 
* master:
  Un-escape new line characters from --releaseNotes arg (firebase#1739)
  update firebase-admin dev dependency (firebase#1741)
  Reject rounds=0 for SHA1 hashes (firebase#1701)
  [firebase-release] Removed change log and reset repo after 7.6.1 release
  7.6.1
  Add Firepit to cloudbuild.yaml (firebase#1637)
  lint rules cleanup x4 (firebase#1721)
  Update template dependencies (firebase#1726)
  Send correct update mask during ext:update (firebase#1724)
  add new ts rules to eslintrc (firebase#1727)
  [firebase-release] Removed change log and reset repo after 7.6.0 release
  7.6.0
  add dev tsconfig for scripts directory (firebase#1720)
  Warn when WSL users don't have Java (firebase#1717)

# Conflicts:
#	CHANGELOG.md
@samtstern samtstern deleted the ss-wsl-no-java branch November 14, 2019 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanpbrewster ryanpbrewster ryanpbrewster approved these changes

@yuchenshi yuchenshi yuchenshi approved these changes

Assignees
No one assigned
Labels
cla: yes Manual indication that this has passed CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When running in WSL emulator does not properly detect lack of 'java' executable
5 participants
@samtstern @coveralls @ryanpbrewster @yuchenshi @googlebot