Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firebase functions experimental shell runtimeconfig #477

Closed
ahaverty opened this issue Sep 28, 2017 · 4 comments
Closed

Firebase functions experimental shell runtimeconfig #477

ahaverty opened this issue Sep 28, 2017 · 4 comments
Assignees

Comments

@ahaverty
Copy link

Version info

"firebase-tools": "3.12.0"
"firebase-admin": "5.2.1",
"firebase-functions": "0.6.3",

Steps to reproduce

On a few occasions, I've ran firebase functions:config:get > .runtimeconfig.json outside of my functions folder.
I'm swapping between a few different projects, and forgetting to cd into /functions
Then getting confused why my config is wrong or doesn't exist after local deploying in shell

Expected behavior

It's probably more of a feature request than a bug:
If firebase experimental:functions:shell could warn about .runtimeconfig.json if it sees there's one on the wrong folder level, that would be helpful

Actual behavior


firebase experimental:functions:shell essentially does exactly what it should be doing.

@laurenzlong laurenzlong self-assigned this Sep 28, 2017
@laurenzlong
Copy link
Contributor

Supporting config automatically during emulation without you having to run "firebase functions:config:get > .runtimeconfig.json" is on our roadmap. Thanks for the validation!

@ppannuto
Copy link

Any update on timeline / estimate here? Been running into this bunch lately :/

Thanks!

@laurenzlong
Copy link
Contributor

laurenzlong commented Jun 19, 2018

I recommend editing the "shell" script in your functions/package.json to be:

firebase functions:config:get > .runtimeconfig.json && firebase functions:shell

That way you can just run "npm run shell`

ppannuto added a commit to lab11/OINK that referenced this issue Jun 20, 2018
This still scares me because if you ever accidentally invoke firebase
shell directly rather than via npm, you could use the wrong config, but
it's better than nothing.

From firebase/firebase-tools#477 (comment)
@thechenky
Copy link
Contributor

Closing for inactivity.

bkendall pushed a commit that referenced this issue Sep 16, 2019
* enables permission checking;

* format
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants