Skip to content

Commit

Permalink
enables permission checking for extensions commands (#477)
Browse files Browse the repository at this point in the history
* enables permission checking;

* format
  • Loading branch information
joehan committed Aug 27, 2019
1 parent d348d54 commit e781e1d
Show file tree
Hide file tree
Showing 6 changed files with 6 additions and 26 deletions.
6 changes: 1 addition & 5 deletions src/commands/ext-configure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ marked.setOptions({
export default new Command("ext:configure <instanceId>")
.description("configure an existing extension instance")
.option("--params <paramsFile>", "path of params file with .env format.")
.before(requirePermissions, [
// this doesn't exist yet, uncomment when it does
// "firebasemods.instances.update"
// "firebasemods.instances.get"
])
.before(requirePermissions, ["firebasemods.instances.update", "firebasemods.instances.get"])
.action(async (instanceId: string, options: any) => {
const spinner = ora.default(
`Configuring ${clc.bold(instanceId)}. This usually takes 3 to 5 minutes...`
Expand Down
5 changes: 1 addition & 4 deletions src/commands/ext-info.ts
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,7 @@ export default new Command("ext:info <extensionName>")
"display information about an extension by name (extensionName@x.y.z for a specific version)"
)
.option("--markdown", "output info in Markdown suitable for constructing a README file")
.before(requirePermissions, [
// this doesn't exist yet, uncomment when it does
// "firebasemods.sources.get"
])
.before(requirePermissions, ["firebasemods.sources.get"])
.before(ensureModsApiEnabled)
.action(async (modName: string, options: any) => {
const sourceUrl = await resolveSource(modName);
Expand Down
5 changes: 1 addition & 4 deletions src/commands/ext-install.ts
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,7 @@ async function installMod(options: InstallModOptions): Promise<void> {
export default new Command("ext:install <extensionName>")
.description("install an extension, given <extensionName> or <extensionName@versionNumber>")
.option("--params <paramsFile>", "name of params variables file with .env format.")
.before(requirePermissions, [
// this doesn't exist yet, uncomment when it does
// "firebasemods.instances.create"
])
.before(requirePermissions, ["firebasemods.instances.create"])
.before(ensureModsApiEnabled)
.action(async (modName: string, options: any) => {
try {
Expand Down
5 changes: 1 addition & 4 deletions src/commands/ext-list.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,7 @@ import * as requirePermissions from "../requirePermissions";

module.exports = new Command("ext:list")
.description("list all the extensions that are installed in your Firebase project")
.before(requirePermissions, [
// TODO: this doesn't exist yet, uncomment when it does
// "firebasemods.instances.list"
])
.before(requirePermissions, ["firebasemods.instances.list"])
.before(ensureModsApiEnabled)
.action((options: any) => {
const projectId = getProjectId(options);
Expand Down
5 changes: 1 addition & 4 deletions src/commands/ext-uninstall.ts
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@ import * as utils from "../utils";
export default new Command("ext:uninstall <extensionInstanceId>")
.description("uninstall an extension that is installed in your Firebase project by instance ID")
.option("-f, --force", "No confirmation. Otherwise, a confirmation prompt will appear.")
.before(requirePermissions, [
// TODO: This doesn't exist yet. Uncomment when it does.
// "firebasemods.instances.delete"
])
.before(requirePermissions, ["firebasemods.instances.delete"])
.before(ensureModsApiEnabled)
.action(async (instanceId: string, options: any) => {
const projectId = getProjectId(options);
Expand Down
6 changes: 1 addition & 5 deletions src/commands/ext-update.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,7 @@ marked.setOptions({
*/
export default new Command("ext:update <instanceId>")
.description("update an existing extension instance to the latest version")
.before(requirePermissions, [
// this doesn't exist yet, uncomment when it does
// "firebasemods.instances.update"
// "firebasemods.instances.get"
])
.before(requirePermissions, ["firebasemods.instances.update", "firebasemods.instances.get"])
.before(ensureModsApiEnabled)
.action(async (instanceId: string, options: any) => {
const spinner = ora.default(
Expand Down

0 comments on commit e781e1d

Please sign in to comment.