Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mila/test mieq race issue #12818

Draft
wants to merge 31 commits into
base: main
Choose a base branch
from
Draft

Mila/test mieq race issue #12818

wants to merge 31 commits into from

Conversation

milaGGL
Copy link
Contributor

@milaGGL milaGGL commented Apr 19, 2024

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in a feature request so that we
    can discuss it together.

@google-oss-bot
Copy link

1 Warning
⚠️ Did you forget to add a changelog entry? (Add #no-changelog to the PR description to silence this warning.)

Generated by 🚫 Danger

@google-oss-bot
Copy link

google-oss-bot commented Apr 19, 2024

Coverage Report 1

Affected Products

  • FirebaseFirestore-iOS-FirebaseFirestoreInternal.framework

    Overall coverage changed from 88.11% (020264b) to 88.20% (2e45f39) by +0.09%.

    FilenameBase (020264b)Merge (2e45f39)Diff
    exception.cc23.68%84.21%+60.53%
    grpc_stream.cc98.02%99.01%+0.99%
    leveldb_key.cc98.82%98.53%-0.29%
    leveldb_mutation_queue.cc92.42%93.56%+1.14%
    query.cc98.43%98.31%-0.12%

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/9ad0bXm0YV.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants