Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve/use shorthand syntax for unwrapping optionals and fix typos #12369

Conversation

sheikhbayazid
Copy link
Contributor

@sheikhbayazid sheikhbayazid commented Feb 7, 2024

Improved code with shorthand syntax for unwrapping optionals and fixed a few typos in documentation.

For example:

This code:

if let error = error { ... }

is replaced with

if let error { ... }

@paulb777
Copy link
Member

paulb777 commented Feb 7, 2024

Thanks for the PR!

Looks like there are some build errors on Xcode 14 in CI which we plan to support for the next few months as long as the App Store does.

@paulb777 paulb777 added this to the Firebase 11 milestone Feb 15, 2024
@paulb777
Copy link
Member

Marking for review and merge for the next major release, when we'll have dropped Xcode 14 support.

@sheikhbayazid
Copy link
Contributor Author

sheikhbayazid commented Feb 16, 2024

Marking for review and merge for the next major release, when we'll have dropped Xcode 14 support.

Great, thanks!

Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paulb777 paulb777 merged commit e8a12e0 into firebase:main May 3, 2024
385 of 388 checks passed
@paulb777 paulb777 modified the milestones: Firebase 11, 10.27.0 - M148 May 3, 2024
Copy link

@romankulkovsf romankulkovsf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ALL good

@sheikhbayazid sheikhbayazid deleted the improve/use-shorthand-syntax-for-unwrapping-optionals-and-fix-typos branch May 4, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants