Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Game center auth #12359

Merged
merged 27 commits into from May 6, 2024
Merged

Game center auth #12359

merged 27 commits into from May 6, 2024

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Feb 6, 2024 •
edited

Adding signing in with game center auth functionality

@pragatimodi pragatimodi changed the title Game center login Game center auth Feb 6, 2024
@renkelvin
Copy link
Contributor

Please fix the CI failure.

paulb777
paulb777 approved these changes Apr 4, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Any assessment of the Game Center functionality based on the new sample code?

FirebaseAuth/Tests/SampleSwift/AuthenticationExampleUITests/AuthenticationExampleUITests.swift Outdated Show resolved Hide resolved
@pragatimodi
Copy link
Contributor Author

pragatimodi commented Apr 8, 2024 •
edited

@paulb777
Tested by @renkelvin using an Apple developer account, it is working as expected.

Base automatically changed from settings-phoneauth to auth-swift May 6, 2024 19:14
@pragatimodi pragatimodi merged commit fe9184f into auth-swift May 6, 2024
48 of 49 checks passed
@pragatimodi pragatimodi deleted the game-center branch May 6, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

@renkelvin renkelvin Awaiting requested review from renkelvin

Assignees
No one assigned
Labels
api: auth
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pragatimodi @renkelvin @google-oss-bot @paulb777