Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An attempt at fixing #12168 by only returning the cached data at the child path rather than at the parent #12169

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

An attempt at fixing #12168 by only returning the cached data at the child path rather than at the parent #12169

wants to merge 1 commit into from

Conversation

mortenbekditlevsen
Copy link
Contributor

Discussion

This attempts to fix the issue reported here:

#12168

Testing

I will be adding tests to this PR.

API Changes

@mortenbekditlevsen
An attempt at fixing firebase#12168 by only returning the cached data…
e78bef4 
… at the child path rather than at the parent
@mortenbekditlevsen
Copy link
Contributor Author

I forgot how to run tests when using SPM, so I haven't had any luck with the testing yet.

@paulb777
Copy link
Member

paulb777 commented Dec 5, 2023

Thanks @mortenbekditlevsen! It looks like the tests pass on CI other than needing clang-format.

@maneesht Would you take a look?

@paulb777
Copy link
Member

paulb777 commented Dec 5, 2023

cc: @aashishpatil-g

@mortenbekditlevsen mortenbekditlevsen mentioned this pull request Dec 31, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maneesht maneesht Awaiting requested review from maneesht

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: database
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mortenbekditlevsen @paulb777