fix: Using alg=none header for custom tokens in emulator mode #541
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is unfortunate. Looks like google-auth discontinued Python 3.5 support a few minor versions ago: https://github.com/googleapis/google-auth-library-python/releases/tag/v1.24.0 |
|
Tried to work around that issue in the tests, but it's not quite working out. Turns out google-cloud-firestore has also dropped Python 3.5 support as of their v2 release. I think we have to just drop Python 3.5 support before we can go ahead. @lahirumaramba FYA |
hiranya911
force-pushed
the
hkj-emulator-alg
branch
from
817a11a
to
3a8a3e0
Compare
|
Rebased on the head of main branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
algheader tononewhen creating custom tokens for the emulator. This requires a recent bug fix in the google-auth package: googleapis/google-auth-library-python#729To enable that I'm also upgrading the corresponding dependencies.