Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix firebase-ios-sdk/#12960 #1188

Merged
merged 5 commits into from
May 14, 2024
Merged

[Bug] Fix firebase-ios-sdk/#12960 #1188

merged 5 commits into from
May 14, 2024

Conversation

ncooke3
Copy link
Member

@ncooke3 ncooke3 commented May 14, 2024

#no-changelog

paulb777
paulb777 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on green

@paulb777 paulb777 mentioned this pull request May 14, 2024
Closed
@ncooke3
Copy link
Member Author

ncooke3 commented May 14, 2024

cc: @morganchen12 for next steps on releasing

@ncooke3 ncooke3 merged commit 6ed31d5 into main May 14, 2024
35 checks passed
@ncooke3 ncooke3 deleted the nc/12960 branch May 14, 2024 20:33
@ncooke3
Copy link
Member Author

ncooke3 commented May 14, 2024

Tested without fix -> error
With fix -> no error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulb777 paulb777 paulb777 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ncooke3 @paulb777