Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(firebase_ui_localizations): Add Finnish language localization labels #332

Merged
merged 3 commits into from Apr 30, 2024

Conversation

launis
Copy link
Contributor

@launis launis commented Apr 18, 2024

Description

This PR adds new language Finnish. The translations are checked but not reviewed by third party.

The melos run analyze noticed error on the original main and these continued to be the same when I did with my changes,

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • [ x] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • [ x] I updated/added relevant documentation (doc comments with ///).
  • [ x] The analyzer (melos run analyze) does not report any problems on my PR.
  • [ x] All unit tests pass (melos run test:unit:all doesn't fail).
  • [ x] I read and followed the Flutter Style Guide.
  • [ x] I signed the CLA.
  • [ x] I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • [ x] No, this is not a breaking change.

Copy link

google-cla bot commented Apr 18, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@launis launis changed the title Added new language Finnish feat: Added new language Finnish Apr 18, 2024
@launis launis marked this pull request as draft April 18, 2024 17:24
@launis launis closed this Apr 18, 2024
@launis launis reopened this Apr 18, 2024
BREAKING CHANGE New language added.
@launis launis closed this Apr 18, 2024
@launis launis reopened this Apr 18, 2024
@launis launis marked this pull request as ready for review April 18, 2024 20:15
@russellwheatley russellwheatley changed the title feat: Added new language Finnish feat(firebase_ui_localizations): Add Finnish language localization labels Apr 24, 2024
Copy link
Member

@russellwheatley russellwheatley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Could you also get a Finnish language speaker to also approve the PR and I will get this merged. Thanks 😄

@russellwheatley russellwheatley added localizations blocked: customer response Waiting for customer response, e.g. more information was requested. labels Apr 24, 2024
Copy link

@TimoPieti TimoPieti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good as a Finnish speaking user. Just a couple of observations.

Correction of Finnish terms and spellings based on the comments given.
Added new statement to the file get_localization.dart, to which "switch and return" line related to the Finnish language was added.
Copy link

@jpsiitonen jpsiitonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked latest changes to translations. LGTM

Copy link

@TimoPieti TimoPieti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me too.

@launis
Copy link
Contributor Author

launis commented Apr 27, 2024

Thanks for the PR! Could you also get a Finnish language speaker to also approve the PR and I will get this merged. Thanks 😄

Approved by two native Finnish speakers.

@launis launis closed this Apr 27, 2024
@launis launis reopened this Apr 28, 2024
@launis
Copy link
Contributor Author

launis commented Apr 28, 2024

Reopened, can be closed when code changes are merged to main.

@russellwheatley russellwheatley merged commit 848b66c into firebase:main Apr 30, 2024
21 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: customer response Waiting for customer response, e.g. more information was requested. localizations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants