Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Vietnamese localization #321

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

chuyentt
Copy link

Description

This PR adds Vietnamese localization to the firebase_ui_localizations package. It includes translations for various labels, error messages, and button texts to support Vietnamese language users. This enhancement aims to improve the user experience for Vietnamese-speaking users, making the Firebase UI components more accessible and user-friendly in the Vietnamese context.

Related Issues

This PR addresses the need for additional language support in the FirebaseUI-Flutter package, specifically adding support for the Vietnamese language. It does not directly resolve any open issues but contributes to the broader goal of internationalizing the FirebaseUI-Flutter package.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • All unit tests pass (melos run test:unit:all doesn't fail).
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Copy link

google-cla bot commented Mar 31, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@chuyentt chuyentt changed the title Add Vietnamese localization feat: Add Vietnamese localization Mar 31, 2024
@russellwheatley
Copy link
Member

@chuyentt - thanks for the PR 😄 . Could you ask another developer fluent in Vietnamese to double check the translations, please? And put an approval on the PR if they are correct 👍

@russellwheatley russellwheatley added the blocked: customer response Waiting for customer response, e.g. more information was requested. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked: customer response Waiting for customer response, e.g. more information was requested.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants