Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More complete support for Pure queries in the Rel transpiler #2622

Conversation

relationalai-opensource
Copy link
Contributor

Various improvements to the Rel transpiler including:

  • Implements complete support for match functions which are now routed.
  • Implements better tracing logic for debugging when a Pure query is not supported by the Rel transpiler, including pretty printing of the intermediate form.
  • Correct handing of the in operator.
  • Fixes handling of at when used along a property path.
  • Necessary changes to the passing of set implementations because the store contact has been updated to ensure that match functions are routed.
  • Tests have been added and updated to improve test coverage.
  • Generated Rel queries are now pretty printed for easier reading and easier to parse Rel.
  • Refactoring and code cleanup. Removing dead code.

What type of PR is this?

Improvement

What does this PR do / why is it needed ?

Support for more types of query by the Rel backend. This PR also improves the logging of errors when a Pure query is not supported by the Rel transpiler.

Does this PR introduce a user-facing change?

This PR is backwards compatible in the sense that existing queries will continue to be supported without any changes.

Copy link

github-actions bot commented Feb 10, 2024

Test Results

0 files  ±0  0 suites  ±0   0s ⏱️ ±0s
0 tests ±0  0 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 284889b. ± Comparison against base commit 939caa6.

♻️ This comment has been updated with latest results.

@andrew-bate-rai
Copy link
Contributor

I have merged master into this branch to fix the merge conflict. It says that merging is blocked because the WhiteSource security check has failed, but the vulnerabilities reported are not related to the changes made in this PR.

pierredebelen
pierredebelen previously approved these changes Apr 5, 2024
@relationalai-opensource
Copy link
Contributor Author

This PR can be closed because it is superseded by PR#2702 which has now been merged.

@andrew-bate-rai
Copy link
Contributor

This PR can be closed because it is superseded by #2702. Apologies for the noise.

@finos-admin
Copy link
Member

This PR is stale because it has been open for 30 days with no activity. Please remove stale label or add any comment to keep this open. Otherwise this will be closed in 5 days.

@finos-admin
Copy link
Member

This PR was closed because it has been inactive for 35 days. Please re-open if this PR is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants