Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PickerView.swift #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update PickerView.swift #44

wants to merge 1 commit into from

Conversation

HanSJin
Copy link

@HanSJin HanSJin commented Apr 6, 2018

No description provided.

@filipealva
Copy link
Owner

Hi @HanSJin, sorry about the delay.

Why are you submitting this change? Does it fix any irregular behavior?

@filipealva
Copy link
Owner

I think I got it.. The way it is today the PickerView wind up sending the index twice instead of the row and the index, right?

If it's about it, I was thinking about stop notifying about the row because what really matters is the index, we as developers using the PickerView component should not care about the actual rows because it is just an amplified version of the index that only exists to make the "endless" scrolling effect.

What do you think about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@HanSJin @filipealva