New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Code Quality: Use RichCommands in home and sidebar #15329
base: main
Are you sure you want to change the base?
Code Quality: Use RichCommands in home and sidebar #15329
Conversation
@@ -73,6 +73,9 @@ public override List<ContextMenuFlyoutItemViewModel> GetItemMenuItems(WidgetCard | |||
{ | |||
return new List<ContextMenuFlyoutItemViewModel>() | |||
{ | |||
new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenInNewTabFromHomeAction).Build(), | |||
new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenInNewWindowFromHomeAction).Build(), | |||
new ContextMenuFlyoutItemViewModelBuilder(CommandManager.OpenInNewPaneFromHomeAction).Build(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these supposed to be here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, any other context menus have them at the top. Should they be placed as were?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the before & after?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
src/Files.App/ViewModels/UserControls/Widgets/DrivesWidgetViewModel.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Actions/Navigation/OpenInNewWindow/OpenInNewWindowAction.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Actions/Navigation/OpenInNewTab/OpenInNewTabAction.cs
Outdated
Show resolved
Hide resolved
src/Files.App/Actions/Navigation/OpenInNewPane/OpenInNewPaneAction.cs
Outdated
Show resolved
Hide resolved
Are the sidebar contexts hidden from the command palette and actions page? |
Ouch, I forgot to do that, will do. |
Done |
Resolved / Related Issues
To prevent extra work, all changes to the Files codebase must link to an approved issue marked as
Ready to build
. Please insert the issue number following the hashtag with the issue number that this Pull Request resolves.Steps used to test these changes
Stability is a top priority for Files and all changes are required to go through testing before being merged into the repo. Please include a list of steps that you used to test this PR.
Confirmed it's working