Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Breaking Change] Split off Shell into separate bundle #643

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

humphd
Copy link
Contributor

@humphd humphd commented Dec 21, 2018

This is part of the work to reduce the size of Filer (see #575), and fixes #290. Our Shell is pretty big, and not always needed. This splits it out into a separate bundle, and if you want it, you include it. Here's the breakdown of our build now:

$ npm run build

> filer@0.0.44 build-filer /Users/humphd/repos/filer/package.json
> parcel build --global Filer src/index.js --out-file filer.min.js --detailed-report

✨  Built in 432ms.

dist/filer.map    347.85 KB    76ms
dist/filer.js     192.61 KB    91ms
✨  Built in 237ms.

dist/filer.min.map                                  288.99 KB    56ms

dist/filer.min.js                                    74.06 KB    65ms
├── src/filesystem/implementation.js                 21.46 KB    21ms
├── node_modules/buffer/index.js                     19.54 KB    17ms
├── src/filesystem/interface.js                       3.84 KB    16ms
├── lib/intercom.js                                   3.76 KB     9ms
├── src/providers/websql.js                            2.5 KB    18ms
├── src/providers/indexeddb.js                        2.21 KB    17ms
├── node_modules/path-browserify/index.js              2.1 KB    23ms
├── node_modules/es6-promisify/dist/promisify.js       1.8 KB    21ms
├── src/node.js                                        1.7 KB     6ms
├── node_modules/process/browser.js                   1.69 KB    23ms
└── + 19 more assets

> filer@0.0.44 build-shell /Users/humphd/repos/filer/package.json
> parcel build --global Shell src/shell/index.js --out-file shell.min.js --detailed-report

✨  Built in 182ms.

dist/shell.map    107.9 KB    34ms
dist/shell.js     72.74 KB    33ms
✨  Built in 175ms.

dist/shell.min.map                                  100.17 KB    30ms

dist/shell.min.js                                    24.01 KB    30ms
├── node_modules/minimatch/minimatch.js               7.32 KB     9ms
├── src/shell/index.js                                3.88 KB     5ms
├── node_modules/path-browserify/index.js              2.1 KB     7ms
├── node_modules/brace-expansion/index.js             2.07 KB     5ms
├── node_modules/es6-promisify/dist/promisify.js       1.8 KB    10ms
├── node_modules/process/browser.js                   1.69 KB     8ms
├── src/constants.js                                  1.65 KB     3ms
├── src/errors.js                                     1.01 KB     6ms
├── lib/async.js                                        795 B     9ms
├── node_modules/balanced-match/index.js                619 B     1ms
└── + 3 more assets

We'll need to use a major version bump for this, since it's a breaking change. I won't land this until I get the update stuff in and working in #640.

@codecov-io
Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #643 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #643      +/-   ##
==========================================
- Coverage   86.56%   86.55%   -0.02%     
==========================================
  Files          16       16              
  Lines        1742     1740       -2     
==========================================
- Hits         1508     1506       -2     
  Misses        234      234
Impacted Files Coverage Δ
src/filesystem/interface.js 93.28% <ø> (-0.09%) ⬇️
src/shell/index.js 88.32% <ø> (ø)
src/index.js 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bfe4385...5d62fbc. Read the comment docs.

@humphd humphd changed the title Split off Shell into separate bundle [Breaking Change] Split off Shell into separate bundle Dec 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

filer should expose only a basic shell
2 participants