Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: merged lines to avoid useless layers #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

janbogdanski
Copy link

@janbogdanski janbogdanski commented Feb 13, 2024

Hey,
Not a game changer but always some MBs saved, each RUN creates layer which occupies space, eg. wget creates file - this is one layer which is always fetched, even this file is removed later. Doing all the cleanings in one RUN makes layers a little bit smaller

After modification
IMAGE          CREATED          CREATED BY                                      SIZE      COMMENT
a1ff72bea407   20 minutes ago   CMD ["apache2-foreground"]                      0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   USER www-data                                   0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   VOLUME [/var/www/filegator/private]             0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   VOLUME [/var/www/filegator/repository]          0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   EXPOSE map[8080/tcp:{}]                         0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   RUN /bin/sh -c sed -ri -e 's!/var/www/html!$…   9.14kB    buildkit.dockerfile.v0
<missing>      20 minutes ago   ENV APACHE_PORT=8080                            0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   ENV APACHE_DOCUMENT_ROOT=/var/www/filegator/…   0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   RUN /bin/sh -c wget https://github.com/fileg…   12.7MB    buildkit.dockerfile.v0
<missing>      20 minutes ago   WORKDIR /var/www/filegator/                     0B        buildkit.dockerfile.v0
<missing>      20 minutes ago   RUN /bin/sh -c apt-get update > /dev/null &&…   57.1MB    buildkit.dockerfile.v0
Original
$ docker history 60ae5728ce0d
IMAGE          CREATED              CREATED BY                                      SIZE      COMMENT
60ae5728ce0d   About a minute ago   CMD ["apache2-foreground"]                      0B        buildkit.dockerfile.v0
<missing>      About a minute ago   USER www-data                                   0B        buildkit.dockerfile.v0
<missing>      About a minute ago   VOLUME [/var/www/filegator/private]             0B        buildkit.dockerfile.v0
<missing>      About a minute ago   VOLUME [/var/www/filegator/repository]          0B        buildkit.dockerfile.v0
<missing>      About a minute ago   EXPOSE map[8080/tcp:{}]                         0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c a2enmod rewrite # buildkit       0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c sed -ri -e 's!80!${APACHE_POR…   1.35kB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c sed -ri -e 's!80!${APACHE_POR…   332B      buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c sed -ri -e 's!/var/www/!${APA…   7.46kB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c sed -ri -e 's!/var/www/html!$…   1.34kB    buildkit.dockerfile.v0
<missing>      About a minute ago   ENV APACHE_PORT=8080                            0B        buildkit.dockerfile.v0
<missing>      About a minute ago   ENV APACHE_DOCUMENT_ROOT=/var/www/filegator/…   0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c chmod -R g+w repository/ # bu…   0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c chmod -R g+w private/ # build…   367B      buildkit.dockerfile.v0
<missing>      About a minute ago   WORKDIR /var/www/filegator/                     0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c chown -R www-data:www-data /v…   12.7MB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c rm filegator_latest.zip # bui…   0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c unzip filegator_latest.zip -d…   12.7MB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c wget https://github.com/fileg…   4.06MB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c docker-php-ext-enable zip # b…   0B        buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c docker-php-ext-install zip # …   72.9kB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c apt-get install -y git libzip…   38.9MB    buildkit.dockerfile.v0
<missing>      About a minute ago   RUN /bin/sh -c apt-get update > /dev/null # …   18.2MB    buildkit.dockerfile.v0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant