feat: expose an API suitable for NI-PoRep proof aggregation #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: add tests to ensure NI-PoRep is tested w and w/o aggregation
DrPeterVanNostrand
previously approved these changes
May 16, 2024
cryptonemo
force-pushed
the
ni-porep-fix-agg
branch
from
5281e3c
to
46281c2
Compare
vmx
reviewed
May 17, 2024
There was a problem hiding this comment.
Just making sure I understand correctly what this is about. In the last step of the Ni-PoRep we aggregate the proofs. We cannot aggregate aggregated proofs. Hence if we want to aggregate several Ni-PoReps, we need the unaggregated result and then aggregate all of them. Is that correct?
Correct, it's specified in the FIP, but wasn't in the implementation. Fortunately it was caught before shipping. |
DrPeterVanNostrand
approved these changes
May 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add tests to ensure NI-PoRep is tested w and w/o aggregation