Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: ci: fix when sorted pr checks workflow is executed #11914

Merged
merged 1 commit into from May 14, 2024

Conversation

galargh
Copy link
Contributor

@galargh galargh commented Apr 22, 2024

Related Issues

#323 (comment)

Proposed Changes

Do not comment when the workflow_run that triggered the sorted PR checks workflow was itself triggered by events other than the pull request event.

Additional Info

The check for github.event.workflow_run.pull_requests[0] is not sufficient because there are PRs with lotus:master as head (e.g. DIGIIX-Ltd#323).

I disabled the workflow until this is merged.

Checklist

Before you mark the PR ready for review, please make sure that:

  • Commits have a clear commit message.
  • PR title is in the form of of <PR type>: <area>: <change being made>
    • example: fix: mempool: Introduce a cache for valid signatures
    • PR type: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, test
    • area, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps
  • If the PR affects users (e.g., new feature, bug fix, system requirements change), update the CHANGELOG.md and add details to the UNRELEASED section.
  • New features have usage guidelines and / or documentation updates in
  • Tests exist for new functionality or change in behavior
  • CI is green

@galargh galargh requested a review from rvagg April 22, 2024 10:39
@rvagg rvagg merged commit d0bbb0b into master May 14, 2024
186 checks passed
@rvagg rvagg deleted the ipdx/fix-sorted-pr-checks branch May 14, 2024 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants