ci: ci: deprecate circle ci in favour of github actions #11786
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Before merging this PR
DOCKERHUB_USERNAME
DOCKERHUB_TOKEN
GORELEASER_KEY
Important
After merging this PR:
lotus
project in CircleCIrelease
branch (?)Related Issues
#11734
Proposed Changes
This PR removes CircleCI configuration from the repository entirely.
Additional Info
We have analysed the CircleCI vs GitHub Actions fitness in the period 2024-04-08 - 2024-04-15:
The analysis suggests we are ready to deprecate CircleCI in favour of GitHub Actions.
master
, onlyTest (itest-gateway)
job is more flaky in GitHub Actions (75% success rate) than in CircleCI (92.86% success rate); there are 8 other tests that are more flaky in CircleCI than in GitHub ActionsBefore proceeding with the deprecation, we should decide whether the tests that we noticed to be flaky/failing only in GitHub Actions should be investigated. Here is a list of the tests (at most 2 failures in 54 runs):
Test (itest-path_type_filters)
Test (itest-eth_filter)
Test (itest-wdpost)
Test (itest-deals_pricing)
Test (itest-sector_finalize_early)
Test (itest-wdpost_worker_config)
Test (itest-cli)
Test (multicore-sdr)
Test (itest-harmonydb)
We should also decide how to proceed with the propagation of deprecation to the release branches. We imagine the course of action to look something like this.
Does it make sense to the team? Are there any other aspects of the process that we should take into account?
Finally, please note that we haven't tested the GitHub Actions release workflows with publishing credentials yet (to avoid duplicate releases). Because of this, we'd suggest coordinating the next release with us - that way we'd be able to immediately react if something unexpected were to happen.
Cost Breakdown
CircleCI
7 Days Total: $354.47
The above figure assumes a CircleCI credit price of $0.0006.
GitHub Actions
7 Days Total: $176.54
Please note that the figures shown cover both self-hosted runners infrastructure, as well as other DX services such as GitHub monitoring, for example.
Checklist
Before you mark the PR ready for review, please make sure that:
<PR type>: <area>: <change being made>
fix: mempool: Introduce a cache for valid signatures
PR type
: fix, feat, build, chore, ci, docs, perf, refactor, revert, style, testarea
, e.g. api, chain, state, market, mempool, multisig, networking, paych, proving, sealing, wallet, deps