FIP-0086: Using max ticket #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant clause
masih
reviewed
Apr 11, 2024
FIPS/fip-0086.md
Outdated
|
|
||
| #### Valid messages and evidence | ||
|
|
||
| The $\texttt{Valid}()$ predicate (referred to in lines 11, 22, 29, and 37) is defined below. | ||
| The $\texttt{Valid}()$ predicate (referred to in lines 10, 22, 34, and 42, and 56) is defined below. |
There was a problem hiding this comment.
Suggested change
| The $\texttt{Valid}()$ predicate (referred to in lines 10, 22, 34, and 42, and 56) is defined below. | |
| The $\texttt{Valid}()$ predicate (referred to in lines 10, 22, 34, and 42, 56 and 58) is defined below. |
|
Following #983, the pseudocode will require some conflict resolution. In the future, please include the FIP number in the title, otherwise this shared repo rapidly becomes confusing. |
ranchalp
force-pushed
the
using-max-ticket
branch
from
d820b45
to
6db29a9
Compare
ranchalp
force-pushed
the
using-max-ticket
branch
from
6db29a9
to
1b80412
Compare
ranchalp
force-pushed
the
using-max-ticket
branch
from
1b80412
to
5940e73
Compare
ranchalp
requested review from
momack2,
arajasek,
jennijuju,
kaitlin-beegle and
anorth
as code owners
ranchalp
force-pushed
the
using-max-ticket
branch
from
5940e73
to
e03abda
Compare
|
Please rebase now #985 has merged. |
|
Done. |
jennijuju
approved these changes
Apr 19, 2024
jsoares
reviewed
Apr 19, 2024
| @@ -294,7 +294,7 @@ The receiver of a message only considers messages with valid signatures and disc | |||
|
|
|||
| Two (or more) messages $m1$ and $m2$ are called _equivocating messages_ if $m1.Sender=m2.Sender \land m1.Instance=m2.Instance \land m1.Value ≠ m2.Value \land m1.MsgType=m2.MsgType \land \texttt(if applicable)\ m1.Round=m2.Round$. We call $m1.Sender$ an _equivocating sender_. | |||
|
|
|||
| A set of messages $M$ that does not contain equivocating messages is called _clean_. Participants discard all equivocating messages when forming clean sets. | |||
| A set of messages $M$ that does not contain equivocating messages is called _clean_. Participants discard all equivocating messages when forming clean sets. In fact, in the proposed version of GossiPBFT in this document, only one of the equivocating messages needs to be stored (thanks to evidences explicitly validating a message). | |||
There was a problem hiding this comment.
Suggested change
| A set of messages $M$ that does not contain equivocating messages is called _clean_. Participants discard all equivocating messages when forming clean sets. In fact, in the proposed version of GossiPBFT in this document, only one of the equivocating messages needs to be stored (thanks to evidences explicitly validating a message). | |
| A set of messages $M$ that does not contain equivocating messages is called _clean_. Participants discard all equivocating messages when forming clean sets, so that only one of the equivocating messages needs to be stored (thanks to the explicit evidence). |
Given this is a spec, I don't think we should refer to "the version proposed in this document" or things like that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to using max ticket instead of min ticket and adjust by power. See here for the analogous in the implementation.
Also specify that there is no need to store equivocating messages.
Built upon the first round of audits #985 , so merge that other PR first.