Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make uploadsLimit into user setting #3204

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

gdy666
Copy link
Contributor

@gdy666 gdy666 commented May 7, 2024

QQ截图20240507222301

@gdy666 gdy666 requested a review from o1egl as a code owner May 7, 2024 14:24
@o1egl
Copy link
Member

o1egl commented May 11, 2024

This PR adds only a client-side naive approach, which can be easily overridden. The proper approach requires server-side implementation as well. Why do we need it in general?

@gdy666
Copy link
Contributor Author

gdy666 commented May 16, 2024

This PR adds only a client-side naive approach, which can be easily overridden. The proper approach requires server-side implementation as well. Why do we need it in general?

The intention of this PR is solely to allow the client to control the number of concurrent file uploads, as in real-world applications, when clients upload files concurrently, upload speed may significantly decrease compared to uploading a single file due to factors such as concurrent disk reads or other performance issues.

001

002

@gdy666
Copy link
Contributor Author

gdy666 commented May 16, 2024

This PR adds only a client-side naive approach, which can be easily overridden. The proper approach requires server-side implementation as well. Why do we need it in general?

By the way, when uploading concurrently, what is displayed here is just the average upload speed. Shouldn't it display the total upload speed instead?

003

004

@Caian
Copy link

Caian commented May 21, 2024

I like this idea very much. I usually update large files to my server, so it is better to have a few files ready versus a lot of files on the fly.

Being a quality-of-life feature for a particular user it is not a problem that it is not enforced on the server-side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants