Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add overlay for sidebar on mobile #3197

Merged
merged 1 commit into from May 19, 2024
Merged

Conversation

kloon15
Copy link
Contributor

@kloon15 kloon15 commented May 5, 2024

Description
Fixes #3190

🚨 Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • AVOID breaking the continuous integration build.

@kloon15 kloon15 requested a review from o1egl as a code owner May 5, 2024 12:47
@gdy666
Copy link
Contributor

gdy666 commented May 5, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'”
Is it more appropriate?

@kloon15
Copy link
Contributor Author

kloon15 commented May 5, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'” Is it more appropriate?

True, I just dont like the gray look of the overlay there and i didnt wanna change the style:
image
I personally dont like the looks of this, everything just blends together with the same gray color.
Whats ur preference @o1egl ?

@o1egl
Copy link
Member

o1egl commented May 11, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'” Is it more appropriate?

True, I just dont like the gray look of the overlay there and i didnt wanna change the style: image I personally dont like the looks of this, everything just blends together with the same gray color. Whats ur preference @o1egl ?

I agree that it doesn't look good in the light theme. Do you have any ideas about how we can improve it?

@kloon15
Copy link
Contributor Author

kloon15 commented May 15, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'” Is it more appropriate?

True, I just dont like the gray look of the overlay there and i didnt wanna change the style: image I personally dont like the looks of this, everything just blends together with the same gray color. Whats ur preference @o1egl ?

I agree that it doesn't look good in the light theme. Do you have any ideas about how we can improve it?

Sure, ill test some ideas over weekend.

@o1egl
Copy link
Member

o1egl commented May 16, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'” Is it more appropriate?

True, I just dont like the gray look of the overlay there and i didnt wanna change the style: image I personally dont like the looks of this, everything just blends together with the same gray color. Whats ur preference @o1egl ?

I agree that it doesn't look good in the light theme. Do you have any ideas about how we can improve it?

Sure, ill test some ideas over weekend.

Should I merge this one, or are you going to revisit it?

@kloon15
Copy link
Contributor Author

kloon15 commented May 16, 2024

the overlay in frontend\src\components\header\HeaderBar.vue Add a display condition “layoutStore.currentPromptName == 'sidebar'” Is it more appropriate?

True, I just dont like the gray look of the overlay there and i didnt wanna change the style: image I personally dont like the looks of this, everything just blends together with the same gray color. Whats ur preference @o1egl ?

I agree that it doesn't look good in the light theme. Do you have any ideas about how we can improve it?

Sure, ill test some ideas over weekend.

Should I merge this one, or are you going to revisit it?

Yes please, so at least we can close the related issue.

@o1egl o1egl merged commit 3b48f75 into filebrowser:master May 19, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mobile sidebar bug
3 participants