Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't redirect to login when no auth #3165

Merged
merged 1 commit into from Apr 28, 2024

Conversation

pmarki
Copy link
Contributor

@pmarki pmarki commented Apr 26, 2024

Don't redirect to login page when there's no authentication

Steps to reproduce:

  1. Set up NoAuth as login provider, wait till session expires
  2. Try to click on any folder/file
  3. You'll be redirected to login page

Expected results:
When NoAuth is used as login provider user is not redirected to login page (as simply there is no login/password). Instead refreshing a page is enough to obtain a new token and to continue browsing.

There is no open issue for this.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • [x ] DO make sure that File Browser can be successfully built. See builds and development.
  • [x ] AVOID breaking the continuous integration build.

@pmarki pmarki requested a review from o1egl as a code owner April 26, 2024 11:49
@gdy666
Copy link
Contributor

gdy666 commented Apr 27, 2024

I found that I can't delete users. It's probably a front-end problem. I'm not familiar with the front-end. Can you check it out?

@pmarki
Copy link
Contributor Author

pmarki commented Apr 27, 2024

Hi @gdy666 Is it related to my changes in this pull request?

@gdy666
Copy link
Contributor

gdy666 commented Apr 27, 2024

Hi @gdy666 Is it related to my changes in this pull request?

Sorry, I didn't express myself clearly, this is unrelated to the PR you submitted, it's just a frontend bug in FileBrowser that I discovered.

@gdy666
Copy link
Contributor

gdy666 commented Apr 28, 2024

Hi @gdy666 Is it related to my changes in this pull request?

Sorry, I didn't express myself clearly, this is unrelated to the PR you submitted, it's just a frontend bug in FileBrowser that I discovered.

Sorry to bother you, I have already fixed it

@o1egl o1egl merged commit da5a6e0 into filebrowser:master Apr 28, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants