Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make checkbox selectable via adjacent text #3090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+47 −36
Open

fix: make checkbox selectable via adjacent text #3090

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
32 changes: 16 additions & 16 deletions frontend/src/components/settings/Permissions.vue
View file
Open in desktop
Expand Up @@ -4,37 +4,37 @@
<p class="small">{{ $t("settings.permissionsHelp") }}</p>

<p>
<input type="checkbox" v-model="admin" />
{{ $t("settings.administrator") }}
<input id="uds-admin" type="checkbox" v-model="admin" />
<label for="uds-admin">{{ $t("settings.administrator") }}</label>
</p>

<p>
<input type="checkbox" :disabled="admin" v-model="perm.create" />
{{ $t("settings.perm.create") }}
<input id="uds-create" type="checkbox" :disabled="admin" v-model="perm.create" />
<label for="uds-create">{{ $t("settings.perm.create") }}</label>
</p>
<p>
<input type="checkbox" :disabled="admin" v-model="perm.delete" />
{{ $t("settings.perm.delete") }}
<input id="uds-delete" type="checkbox" :disabled="admin" v-model="perm.delete" />
<label for="uds-delete">{{ $t("settings.perm.delete") }}</label>
</p>
<p>
<input type="checkbox" :disabled="admin" v-model="perm.download" />
{{ $t("settings.perm.download") }}
<input id="uds-download" type="checkbox" :disabled="admin" v-model="perm.download" />
<label for="uds-download">{{ $t("settings.perm.download") }}</label>
</p>
<p>
<input type="checkbox" :disabled="admin" v-model="perm.modify" />
{{ $t("settings.perm.modify") }}
<input id="uds-modify" type="checkbox" :disabled="admin" v-model="perm.modify" />
<label for="uds-modify">{{ $t("settings.perm.modify") }}</label>
</p>
<p v-if="isExecEnabled">
<input type="checkbox" :disabled="admin" v-model="perm.execute" />
{{ $t("settings.perm.execute") }}
<input id="uds-execute" type="checkbox" :disabled="admin" v-model="perm.execute" />
<label for="uds-execute">{{ $t("settings.perm.execute") }}</label>
</p>
<p>
<input type="checkbox" :disabled="admin" v-model="perm.rename" />
{{ $t("settings.perm.rename") }}
<input id="uds-rename" type="checkbox" :disabled="admin" v-model="perm.rename" />
<label for="uds-rename">{{ $t("settings.perm.rename") }}</label>
</p>
<p>
<input type="checkbox" :disabled="admin" v-model="perm.share" />
{{ $t("settings.perm.share") }}
<input id="uds-share" type="checkbox" :disabled="admin" v-model="perm.share" />
<label for="uds-share">{{ $t("settings.perm.share") }}</label>
</p>
</div>
</template>
Expand Down
7 changes: 5 additions & 2 deletions frontend/src/components/settings/Rules.vue
View file
Open in desktop
@@ -1,8 +1,11 @@
<template>
<form class="rules small">
<div v-for="(rule, index) in rules" :key="index">
<input type="checkbox" v-model="rule.regex" /><label>Regex</label>
<input type="checkbox" v-model="rule.allow" /><label>Allow</label>
<input :id="'regex-'+index" type="checkbox" v-model="rule.regex" />
<label :for="'regex-'+index" >Regex</label>

<input :id="'allow-'+index" type="checkbox" v-model="rule.allow" />
<label :for="'allow-'+index">Allow</label>

<input
@keypress.enter.prevent
Expand Down
3 changes: 2 additions & 1 deletion frontend/src/components/settings/UserForm.vue
View file
Open in desktop
Expand Up @@ -51,8 +51,9 @@
type="checkbox"
:disabled="user.perm.admin"
v-model="user.lockPassword"
id="user-lock-pass"
/>
{{ t("settings.lockPassword") }}
<label for="user-lock-pass">{{ t("settings.lockPassword") }}</label>
</p>
<permissions v-model:perm="user.perm" />
Expand Down
14 changes: 9 additions & 5 deletions frontend/src/css/dashboard.css
View file
Open in desktop
Expand Up @@ -32,12 +32,16 @@ a {
color: inherit;
}

.dashboard p label {
.dashboard p input[type="checkbox"] {
cursor: pointer;
vertical-align: middle;
margin-bottom: 0.2em;
display: block;
font-size: 0.8em;
font-weight: 500;
color: var(--textPrimary);
}
.dashboard p label {
margin-left: 0.35em;
vertical-align: bottom;
display: inline-block;
cursor: pointer;
}

li code,
Expand Down
2 changes: 2 additions & 0 deletions frontend/src/css/styles.css
View file
Open in desktop
Expand Up @@ -417,6 +417,7 @@ html[dir="rtl"] .breadcrumbs .chevron {

.rules input[type="checkbox"] {
margin-right: 0.2rem;
cursor: pointer;
}

.rules input[type="text"] {
Expand All @@ -426,6 +427,7 @@ html[dir="rtl"] .breadcrumbs .chevron {

.rules label {
margin-right: 0.5rem;
cursor: pointer;
}

.rules button {
Expand Down
13 changes: 7 additions & 6 deletions frontend/src/views/settings/Global.vue
View file
Open in desktop
Expand Up @@ -9,13 +9,14 @@

<div class="card-content">
<p>
<input type="checkbox" v-model="settings.signup" />
{{ t("settings.allowSignup") }}
<input id="allowSignup" type="checkbox" v-model="settings.signup" />
<label for="allowSignup">{{ t("settings.allowSignup") }}</label>
</p>

<p>
<input type="checkbox" v-model="settings.createUserDir" />
{{ t("settings.createUserDir") }}
<input id="createUserDir" type="checkbox" v-model="settings.createUserDir" />
<label for="createUserDir">{{ t("settings.createUserDir") }}</label>

</p>

<div>
Expand Down Expand Up @@ -64,7 +65,7 @@
v-model="settings.branding.disableExternal"
id="branding-links"
/>
{{ t("settings.disableExternalLinks") }}
<label for="branding-links">{{ t("settings.disableExternalLinks") }}</label>
</p>

<p>
Expand All @@ -73,7 +74,7 @@
v-model="settings.branding.disableUsedPercentage"
id="branding-used-disk"
/>
{{ t("settings.disableUsedDiskPercentage") }}
<label for="branding-used-disk">{{ t("settings.disableUsedDiskPercentage") }}</label>
</p>

<p>
Expand Down
12 changes: 6 additions & 6 deletions frontend/src/views/settings/Profile.vue
View file
Open in desktop
Expand Up @@ -8,16 +8,16 @@

<div class="card-content">
<p>
<input type="checkbox" name="hideDotfiles" v-model="hideDotfiles" />
{{ t("settings.hideDotfiles") }}
<input id="hideDotfiles" type="checkbox" name="hideDotfiles" v-model="hideDotfiles" />
<label for="hideDotfiles">{{ t("settings.hideDotfiles") }}</label>
</p>
<p>
<input type="checkbox" name="singleClick" v-model="singleClick" />
{{ t("settings.singleClick") }}
<input id="singleClick" type="checkbox" name="singleClick" v-model="singleClick" />
<label for="singleClick">{{ t("settings.singleClick") }}</label>
</p>
<p>
<input type="checkbox" name="dateFormat" v-model="dateFormat" />
{{ t("settings.setDateFormat") }}
<input id="dateFormat" type="checkbox" name="dateFormat" v-model="dateFormat" />
<label for="dateFormat">{{ t("settings.setDateFormat") }}</label>
</p>
<h3>{{ t("settings.language") }}</h3>
<languages
Expand Down