Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add button to navigate up to .. (parent dir) #3089

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tox2ik
Copy link

@tox2ik tox2ik commented Apr 2, 2024

Description

This adds a button to the static set of buttons in the upper-right corner. When clicked, the browser navigates one level up the folder hierarchy. I think this is a crucial input/action to have in a browser.

I would prefer to have it closer to the logo (on the left side), but people probably put branding there, or whatever, so I decided to just stick it with the other buttons.

This is a new feature. No issues exist for this as far as I am aware.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • [?] AVOID breaking the continuous integration build.
$make build (…)
found 0 vulnerabilities (…)
✓ 188 modules transformed. (…)
✓ built in 20.20s 

Further comments

I'm not sure if the last two check can be ticked off, yet. I'll update the PR when I am.

...How do I check the last point? I guess you don't want to use up all the free time on the builder. Not sure how to proceed here.

I have a couple of questions:

  • am I supposed to add the new "gettext" localization strings to all the other language file or just the one that I'm using? Is there some automation in place to help updating those files?

@tox2ik tox2ik marked this pull request as ready for review April 2, 2024 03:34
@tox2ik tox2ik requested a review from o1egl as a code owner April 2, 2024 03:35
@o1egl
Copy link
Member

o1egl commented Apr 24, 2024

Thank you for your message. Our UI already includes parent directory navigation. Can you please explain how this button will be more useful?
Screenshot 2024-04-24 at 23 40 00

@tox2ik
Copy link
Author

tox2ik commented Apr 26, 2024

The breadcrumbs are not visible when you scroll down. This button is more useful because it's possible to navigate back/up to the parent without scrolling back to the top of the file listing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants