New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add open in new tab link #3059
base: master
Are you sure you want to change the base?
Conversation
It's already fixed in #3004 and #3052 in a common way. you can test it here:https://github.com/niubility000/filebrowser/archive/refs/heads/feat-005-stay-in-the-same-position-of-the-list-when-back-from-a-sub-folder.zip |
I do agree that the layout is not good, especially in list mode. I don't understand "it doesn't work in the simple list mode". It doesn't look pretty, but the link is there and opens in a new tab. The layout issue is fixable, and an icon could be prettier, but I first wanted to first know if you are interested in this feature or not. What is weird with iPhone? I tried on my android, and it opens a new tab. Another problem is the "Use single clicks to open files and directories". If this is enabled, clicking the "open in new tab" also triggers the "onClick" of the item. |
This is a terrible way to add this standard behavior (bear with me, i'm not criticizing you):
OR... Right now there is a To make this semantically and functionally correct there should be an anchor around the name of the folder At the very least, what is proposed in this PR, I think should be an opt-in, default-off feature via user-profile settings, but hopefully you agree that the So overall, I do see the utility in being able to open in a new tab, but the current solution is not good. I have proposed an alternative approach that is the standard way to solve this in HTML, and would be supported on mobile via "long press" or what have you... |
Thank you for this proposal, but from the ui/ux perspective this implementation is not good. I agree with @tox2ik . I think it would be beter if we simply use the native right-click popup window |
U can just simply use middle click to open a link in new tab. |
Description
For each file in the file list, add a link to open it in a new tab.
This is useful when you have a folder with a lot of files, as otherwise when hitting the back button, you may have to scroll the file list again.
My current code doesn't display a pretty button or anything, but it works for me. Would you open to integrate a feature like that?
馃毃 Before submitting your PR, please indicate which issues are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
make test frontend
Further comments
Screenshot of filebrowser serving itself with this PR: