Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to share folder for view rendering #3057

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jsheely
Copy link

@jsheely jsheely commented Mar 19, 2024

Myself and a number of issues have been raised requesting the ability to have html content that can be served and rendered instead of only downloaded.

This PR is starting that conversation and adds a functional but crude implementation of the designed feature

  • A folder has a new share icon that allows for sharing a "view" folder. Any file in that folder is now viewable
  • Adds new /view route to router to handle this. Simply removes the Content-Disposition header conditionally

A user could now share a directory that contains a HTML, Vue or React for website for example directly from within FileBrowser

Current limitations

  • Only available directly on sharing a folder
  • Share icon not added everywhere you might want to share a folder/file directly for rendering

Looking for feedback before completion.

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Apr 18, 2024
@jsheely
Copy link
Author

jsheely commented Apr 18, 2024

@o1egl Looking for feedback if this is something you're interested in bringing into the project. I can scaffold out the rest of the feature then.

@github-actions github-actions bot removed the Stale label Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant