Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add context menu for file listing #2871

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

omalk98
Copy link
Contributor

@omalk98 omalk98 commented Dec 9, 2023

Description

Added context menu on right click. Maps directly to all addressable header bar actions.

Context Menu Features

  • 1-to-1 mapping of the header bar actions except (toggle shell, switch view, select multiple)
  • Double right-click to cancel custom context menu callback and trigger default browser context-menu
  • Container aware (will not overflow outside screen bounds when opened by the bottom right corner of screen)

Context Menu States:

Single File:
image

Multiple Files
image

No File:
image

Reasons to Merge

Long requested feature, has been referenced in the following issues:

#512
#752
#1031
#1276
#1782
#2609

馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.

  • DO make sure you are requesting to pull a topic/feature/bugfix branch (right side). Don't request your master!
  • DO make sure you are making a pull request against the master branch (left side). Also you should start your branch off our master.
  • DO make sure that File Browser can be successfully built. See builds and development.
  • DO make sure that related issues are opened in other repositories. I.e., the frontend, caddy plugins or the web page need to be updated accordingly.
  • AVOID breaking the continuous integration build.

@omalk98 omalk98 requested a review from o1egl as a code owner December 9, 2023 19:29
Copy link

github-actions bot commented Feb 3, 2024

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Feb 3, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Feb 3, 2024

Bump

@github-actions github-actions bot removed the Stale label Feb 4, 2024
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Mar 12, 2024
@omalk98
Copy link
Contributor Author

omalk98 commented Mar 12, 2024

Bump

@github-actions github-actions bot removed the Stale label Mar 13, 2024
@o1egl
Copy link
Member

o1egl commented Apr 25, 2024

Can you please merge the latest master and resolve conflicts?

@omalk98
Copy link
Contributor Author

omalk98 commented Apr 25, 2024

Can you please merge the latest master and resolve conflicts?

Will do, I'll get on to it sometime early May.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants