Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Show the current users name in the sidebar #2821

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

JonathanBout
Copy link

@JonathanBout JonathanBout commented Nov 10, 2023

Description
This pull request adds a line to the sidebar with the username:
sidebar with admin username
When clicked, you will be sent to the user settings. It also modifies the behavior of the settings button, which now redirects to the global settings and will be hidden when the current user doesn't have the rights for that page.

To make this possible, the backend is modified to also send the username which wasn't sent before.

(resolves #2692)

@JonathanBout JonathanBout changed the title Show the current users name in the sidebar feat: Show the current users name in the sidebar Nov 18, 2023
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jan 30, 2024
@JonathanBout
Copy link
Author

ping && @o1egl any word on this?

@niubility000
Copy link
Contributor

Why the checks are 0?
lint Expected — Waiting for status to be reported?
Is it out of date or something wrong?

@JonathanBout
Copy link
Author

@niubility000 as it states (at least for me):

This workflow requires approval from a maintainer. Learn more about approving workflows.
2 expected checks

It can't be merged and won't be linted nor tested without approval

@niubility000
Copy link
Contributor

@niubility000 as it states (at least for me):

This workflow requires approval from a maintainer. Learn more about approving workflows.
2 expected checks

It can't be merged and won't be linted nor tested without approval

Oh, I know. It's your first time to Pull a request. It needs maintainer to approve to run the checks.

@Platway
Copy link

Platway commented Apr 7, 2024

I was just about to request this feature and found this pull request. Hope it will be released soon. Thanks everyone!

Copy link
Member

@o1egl o1egl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think addind user and especially logout to the top of the side panel is a good ux practice. There should be a better way to visualize it

frontend/src/components/Sidebar.vue Show resolved Hide resolved
frontend/src/components/Sidebar.vue Outdated Show resolved Hide resolved
@JonathanBout JonathanBout requested a review from o1egl April 26, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Show the username of the current user
4 participants