New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Show the current users name in the sidebar #2821
base: master
Are you sure you want to change the base?
feat: Show the current users name in the sidebar #2821
Conversation
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
ping && @o1egl any word on this? |
Why the checks are 0? |
@niubility000 as it states (at least for me):
It can't be merged and won't be linted nor tested without approval |
Oh, I know. It's your first time to Pull a request. It needs maintainer to approve to run the checks. |
I was just about to request this feature and found this pull request. Hope it will be released soon. Thanks everyone! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think addind user and especially logout to the top of the side panel is a good ux practice. There should be a better way to visualize it
Description
This pull request adds a line to the sidebar with the username:
When clicked, you will be sent to the user settings. It also modifies the behavior of the settings button, which now redirects to the global settings and will be hidden when the current user doesn't have the rights for that page.
To make this possible, the backend is modified to also send the username which wasn't sent before.
(resolves #2692)