feat: add Read/Write Permission #2550
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
o1egl
requested changes
Jul 17, 2023
Comment on lines
+76
to
+78
| if !d.CheckReadPerm(r.URL.Path) { | ||
| return http.StatusForbidden, nil | ||
| } |
There was a problem hiding this comment.
I don't think read permission should be checked here
http/data.go
Outdated
Comment on lines
88
to
92
| if !rule.Allow { | ||
| write = false | ||
| } else { | ||
| write = strings.Contains(rule.Perm, "write") | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !rule.Allow { | |
| write = false | |
| } else { | |
| write = strings.Contains(rule.Perm, "write") | |
| } | |
| if !rule.Allow { | |
| write = false | |
| continue | |
| } | |
| write = strings.Contains(rule.Perm, "write") |
http/data.go
Outdated
Comment on lines
98
to
102
| if !rule.Allow { | ||
| write = false | ||
| } else { | ||
| write = strings.Contains(rule.Perm, "write") | ||
| } |
There was a problem hiding this comment.
Suggested change
| if !rule.Allow { | |
| write = false | |
| } else { | |
| write = strings.Contains(rule.Perm, "write") | |
| } | |
| if !rule.Allow { | |
| write = false | |
| continue | |
| } | |
| write = strings.Contains(rule.Perm, "write") |
o1egl
reviewed
Jul 22, 2023
Comment on lines
+26
to
29
| type Perms struct { | ||
| Read bool `json:"read"` | ||
| Write bool `json:"write"` | ||
| } |
There was a problem hiding this comment.
Looks like this struct is not used
Comment on lines
+54
to
+66
| const rule = this.rules[index]; | ||
| const isRead = | ||
| ruleName === "read" | ||
| ? rule.perm.includes("read") | ||
| : !rule.perm.includes("read"); | ||
| const isWrite = | ||
| ruleName === "write" | ||
| ? rule.perm.includes("write") | ||
| : !rule.perm.includes("write"); | ||
| this.rules[index].perm = `${!isRead ? "read" : ""}${ | ||
| !isRead && !isWrite ? "|" : "" | ||
| }${!isWrite ? "write" : ""}`; | ||
| }, |
There was a problem hiding this comment.
Why not to store it as an inner object?
perms: {read: true, write: true}
o1egl
reviewed
Jul 22, 2023
Comment on lines
+61
to
+63
| } else { | ||
| read = strings.Contains(rule.Perm, "read") | ||
| } |
There was a problem hiding this comment.
Let's follow the same code style as in CheckWritePerm
Comment on lines
+71
to
+73
| } else { | ||
| read = strings.Contains(rule.Perm, "read") | ||
| } |
o1egl
force-pushed
the
master
branch
2 times, most recently
from
813c2e9
to
66dfbb3
Compare
|
This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days. |
|
This PR was closed because it has been stalled for 5 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Read/Write permission to filebrowser.
It works like ACL in linux
馃毃 Before submitting your PR, please read community, and indicate which issues (in any of the repos) are either fixed or closed by this PR. See GitHub Help: Closing issues using keywords.
Further comments
None.