Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Missing Tenant Registration, Profile and User Profile page component registration #12844

Conversation

dev-idkwhoami
Copy link
Contributor

Description

Currently it not possible to use these features as they simply don't get registered with Livewire. This probably wont bug you if you have no form on those sites but as soon as something needs to be submitted through livewire it will throw an exception since it has no knowledge of these components.

This PR is in response to issue #12837

Visual changes

Visually no changes for screenshots about the problem check the issue #12837

Functional changes

  • Code style has been fixed by running the composer cs command.
  • Changes have been tested to not break existing functionality.
  • Documentation is up-to-date.

@danharrin danharrin added the enhancement New feature or request label May 20, 2024
@danharrin danharrin added this to the v3 milestone May 20, 2024
@danharrin danharrin linked an issue May 20, 2024 that may be closed by this pull request
@danharrin
Copy link
Member

The reason why you're the only one who has reported this is not because there aren't others who use the feature. It's because the pages are outside your registered Filament pages directory:

https://github.com/dev-idkwhoami/filament-livewire-form-on-tenant-profile-page/blob/master/app/Providers/Filament/NonpluginPanelProvider.php#L41-L46

Filament will auto-register all Livewire components in the pages, resources and widgets namespaces, and Livewire registers within App/Livewire. Your pages are outside all of those directories, hence why they are not registered.

The fixes for the other auth pages were implemented by someone in a similar situation to you, the tenant pages probably didn't exist at that time though.

@danharrin danharrin merged commit 5cb4af7 into filamentphp:3.x May 20, 2024
10 checks passed
@dev-idkwhoami dev-idkwhoami deleted the fix/missing-page-component-registrations branch May 20, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Tenant Pages Livewire Component Error
2 participants