Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update cmdk to 1.0.0, add simple filter for Command components for better ranking, address an issue with cmdk 1.0.0 regarding disabled items in dropdown #59

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

chore: Update cmdk to 1.0.0, add simple filter for Command components for better ranking, address an issue with cmdk 1.0.0 regarding disabled items in dropdown #59

wants to merge 6 commits into from

Conversation

SamZhang02
Copy link
Collaborator

No description provided.

@SamZhang02 SamZhang02 changed the title chore: Update cmdk to 1.0.0 chore: Update cmdk to 1.0.0, add simple filter for Command components for better ranking May 5, 2024
@SamZhang02
Copy link
Collaborator Author

@itsjoeoui do you mind trying out on your side this one specific thing when you have time:
In the select currency dropdown, the typing in the first and second letter has a little bit of lag on my side due to the filter thing; it's not THAT noticeable for me tho so I wanted to see your opinion. It's most likely the toLowercase() being slow

@SamZhang02 SamZhang02 marked this pull request as ready for review May 5, 2024 18:50
@SamZhang02 SamZhang02 requested a review from itsjoeoui as a code owner May 5, 2024 18:50
@SamZhang02 SamZhang02 changed the title chore: Update cmdk to 1.0.0, add simple filter for Command components for better ranking chore: Update cmdk to 1.0.0, add simple filter for Command components for better ranking, address an issue with cmdk 1.0.0 regarding disabled items in dropdown May 5, 2024
@itsjoeoui
Copy link
Member

still on vacation haha, will review this when I get back 💯

@SamZhang02
Copy link
Collaborator Author

dw bro enjoy the foooooods

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjoeoui itsjoeoui Awaiting requested review from itsjoeoui itsjoeoui is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamZhang02 @itsjoeoui