gdf event reading

[schoffelen]

This is an attempt to read in events from a biosemi/gdf file, where the events are represented in the header (and not in the trigger channel)

[schoffelen]

I think it's a clean PR, but I still need to dig up some example data and write a test function.

Also, I should at some point clean up the empty merge messages that somehow keep lingering in my fork's history

[github-actions]

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_yorkinstruments, test_pull2050, test_read_trigger, test_issue1585, test_pull731, test_bug1262

When inside the DCCN, please also consider testing: test_bug1924, test_issue789, test_issue1972, test_pull769, test_bug1407, test_yorkinstruments, test_issue1585, test_bug2093, test_bug2060, test_pull1271, test_bug2887, test_bug1262, test_issue2026, test_bug3207, inspect_bug645, test_bug3027, test_pull731, test_bug629, test_bug2170, test_curry, test_bug2415, test_issue1387, test_pull1229, test_bug1266, test_bug1914, test_pull1248

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

[github-actions]

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_pull731, test_issue1585, test_pull2050, test_bug1262, test_read_trigger, test_yorkinstruments

When inside the DCCN, please also consider testing: test_pull1248, test_bug3027, test_bug1914, test_issue1387, test_bug1407, test_bug1262, test_bug3207, test_bug1924, test_bug2887, test_bug2170, inspect_bug645, test_pull1229, test_curry, test_pull1271, test_issue789, test_bug2415, test_bug1266, test_pull731, test_pull769, test_bug2093, test_issue1585, test_bug629, test_issue2026, test_bug2060, test_issue1972, test_yorkinstruments

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

[github-actions]

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_pull731, test_yorkinstruments, test_bug1262, test_issue1585, test_pull2050, test_read_trigger

When inside the DCCN, please also consider testing: test_bug1407, test_bug629, test_bug1262, test_pull1229, test_issue2026, test_yorkinstruments, test_pull769, test_bug1266, test_pull1248, test_bug2060, test_bug3027, test_bug2170, inspect_bug645, test_curry, test_issue789, test_pull1271, test_bug1924, test_bug2415, test_issue1972, test_bug2887, test_bug1914, test_pull731, test_issue1387, test_bug3207, test_issue1585, test_bug2093

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

[github-actions]

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_issue1585, test_read_trigger, test_pull731, test_pull2050, test_bug1262, test_yorkinstruments

When inside the DCCN, please also consider testing: test_pull1229, test_bug1924, test_issue1387, test_pull769, test_pull1248, test_pull731, test_pull1271, test_bug2415, test_curry, test_issue789, test_bug629, inspect_bug645, test_bug2887, test_issue1972, test_issue1585, test_bug1266, test_bug2170, test_bug1407, test_bug2060, test_bug1262, test_yorkinstruments, test_bug1914, test_bug2093, test_bug3207, test_issue2026, test_bug3027

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

[schoffelen]

Aaargh, why does the diff now also include a change to data2bids? I will close this and create a new clean PR with only the intended changes.

[schoffelen]

hmm, but upon second thought, the change to data2bids is due to a commit included by @robertoostenveld into this PR... Do you think it's safe to merge the PR from here?

[robertoostenveld]

huh, what is my commit to data2bids doing here?

Could you rebase your commit onto the master to clean it up?

[schoffelen]

I'll try but always get nervous when I have to find out what voodoo steps and pinkel commands to execute

[github-actions]

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When outside the DCCN, please consider testing: test_yorkinstruments, test_pull731, test_read_trigger, test_issue1585, test_bug1262, test_pull2050

When inside the DCCN, please also consider testing: test_yorkinstruments, test_bug2093, test_bug629, test_issue1585, inspect_bug645, test_bug1266, test_pull1229, test_issue1387, test_bug2415, test_pull769, test_bug1262, test_bug2170, test_issue2026, test_bug1924, test_bug2060, test_bug3207, test_pull731, test_issue1972, test_pull1248, test_bug2887, test_issue789, test_bug3027, test_curry, test_bug1914, test_bug1407, test_pull1271

Suggested tests outside the DCCN use public data or do not use data.
Suggested tests inside the DCCN use private data.

[schoffelen]

phew, the rebasing went more smoothly than I feared. Ready to be merged as far as I am concerned.

[robertoostenveld]

looks good to me, I will merge.

[robertoostenveld]

I think that my commit appeared on your gdf branch because of the following:

• you branched off your gdf branch
• you made commits on your gdf branch
• I made commits on the master branch
• you merged the master branch in your gdf branch

That caused my commits on master to appear on your gdf branch. By rebasing you moved your commits to a later point in time, after my commits. The diff between your rebased gdf and the (by now updated) master therefore did not show them any more.

I think that without the rebase upon a merge, git would also have properly resolved the commits that in your branch were in a different order than on master. But better safe than sorry.

[schoffelen]

I think that my commit appeared on your gdf branch because of the following:

• you branched off your gdf branch
• you made commits on your gdf branch
• I made commits on the master branch
• you merged the master branch in your gdf branch

That caused my commits on master to appear on your gdf branch. By rebasing you moved your commits to a later point in time, after my commits. The diff between your rebased gdf and the (by now updated) master therefore did not show them any more.

I think that without the rebase upon a merge, git would also have properly resolved the commits that in your branch were in a different order than on master. But better safe than sorry.

Yup, indeed I think that all this started when I pulled the branch (which I started on my laptop) into the repo that I have on the cluster. I might have done a git pull upstream on the master branch before creating the gdf branch, and pulling it from origin.