Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX #2352 - open file using ASCII-US encoding #2356

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

robertoostenveld
Copy link
Contributor

@schoffelen I wonder whether we should do this more explicitly for other file formats as well. We don't encounter this problem very often, but this certainly not the first time.

At other places in the code we do it explicitly when reading, for example

char(fread(fid, 16, 'uint8=>char'))

I think that any piece of code that freads a char without explicit specification of the character encoding is at risk.

Copy link

github-actions bot commented Dec 6, 2023

You should test whether your modifications do not break anything.
See https://www.fieldtriptoolbox.org/development/testing/

When inside the DCCN, please also consider testing: test_nicolet_reading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant