Update ft_plot_layout #2344
Open
Update ft_plot_layout #2344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filled in missing lines and tried to make the doc more helpful generally.
Make parameter expansion a bit more robust, so that it expands any of the three marker parameter (symbol, size and color). It would expand previously only if the number of colors specifically was more than 1.
|
You should test whether your modifications do not break anything. When outside the DCCN, please consider testing: test_ft_prepare_layout, test_ft_plot_layout |
|
I looked at the suggested tests. Both only call ft_plot_layout(layout), that is without additional parameters, so they won't be affected by the change. |
|
I looked through the codebase and found 3functions that call ft_plot_layout with marker properties: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to improve a bit the doc of ft_plot_layout, mainly to make clearer you can set different colors, symbols or sizes per marker (#1116). Additionally, I tried to make parameter expansion a bit more robust, so that it expands any of the three marker parameter (symbol, size and color). It would expand previously only if the number of colors specifically was more than 1.