Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add -ss flag to stop at first successful response (#571) #586

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

xbol0
Copy link

@xbol0 xbol0 commented Sep 7, 2022

Description

Added -ss flag to stop at first successful response.

I think that it should be conflict to other stop flags. So I made it throw a warning message when user provided them.

Fixes: #571

Additonally

  • If this is the first time you are contributing to ffuf, add your name to CONTRIBUTORS.md.
    The file should be alphabetically ordered.
  • Add a short description of the fix to CHANGELOG.md

Thanks for contributing to ffuf :)

@joohoi
Copy link
Member

joohoi commented Feb 3, 2023

Thanks for the PR, and sorry it took so long to get around to review it.

I do like the idea for the flag, but I would argue that we should modify the behavior a bit from this initial suggestion. If I'm not mistaken the potential use case example for this is to fuzz things like credentials and such, and for that I believe we should abstract the definition of success a bit. So how about changing the behavior to stop on first match instead of hardcoded status codes etc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Stop at first successfull response
2 participants