Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): context stage 1 #349

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

Archento
Copy link
Member

@Archento Archento commented Apr 19, 2024

This is the first iteration of Context refactoring where all agent related properties within the context are clustered to one ctx.agent property. This is possible with the new AgentRepresentation class and enables lean passthrough of necessary properties without exposing unnecessary interfaces.

context_refactor-Page-3

@Archento Archento marked this pull request as ready for review April 22, 2024 13:04
@Archento Archento requested a review from lrahmani April 22, 2024 14:07
Copy link
Contributor

@jrriehl jrriehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since there are a few breaking changes here, I think we just need to compile a list of them somewhere that we can include in release notes, docs, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants