modernize #51
Open
modernize #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KayleePop
reviewed
Sep 1, 2018
KayleePop
reviewed
Sep 1, 2018
index.js
Outdated
| if (!opts) opts = {} | ||
| if (!cb) cb = function () {} | ||
| if (!cb) cb = () => {} |
There was a problem hiding this comment.
A default parameter could be used here instead
function append (file, rootElem, opts, cb = () => {}) {
KayleePop
reviewed
Sep 1, 2018
index.js
Outdated
| @@ -170,7 +160,7 @@ function renderMedia (file, getElem, opts, cb) { | |||
| } | |||
|
|
|||
| function useVideostream () { | |||
| debug('Use `videostream` package for ' + file.name) | |||
| debug(`Use 'videostream\` package for ${file.name}`) | |||
There was a problem hiding this comment.
I think you replaced a backtick with a single quote here. To output the same string you'd need
`Use \`videostream\` package...`
18 tasks
|
I think if we fix the conflicts this could be merged. @jimmywarting? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
webtorrent/webtorrent#1443