fix(bucket-utils): small fix for async race condition #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ensure that deletePublicAccessBlock is allowed to run before moving on from bucket creation
|
@mikejpeters Sorry, missed this off the last PR, can we cut a new release with this fix in it? 🙏 |
Codecov Report
@@ Coverage Diff @@
## master #186 +/- ##
=======================================
Coverage 85.26% 85.26%
=======================================
Files 6 6
Lines 346 346
=======================================
Hits 295 295
Misses 51 51
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Shereef
approved these changes
Apr 28, 2023
|
🎉 This PR is included in version 4.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
Thank you so much for catching it and resubmitting a PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ensure that deletePublicAccessBlock is allowed to run before moving on from bucket creation.
Following on from the fix I did a few days ago around the breaking S3 policy change, I missed a return here to ensure that the
deletePublicAccessBlockcall is completed before moving on. We still see occasional errors owing to this race condition.