Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): updating sdk invocation versions #3393

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

bsinghvi
Copy link
Contributor

Used the generator versions here - https://github.com/fern-api/fern?tab=readme-ov-file + the changelog to decide on the default version.

@bsinghvi bsinghvi requested a review from dsinghvi as a code owner April 17, 2024 23:34
@dsinghvi
Copy link
Member

@bsinghvi you'll need to fix ete tests here yarn workspace @fern-api/ete-tests test -u and then we are g2g

@dannysheridan
Copy link
Member

dannysheridan commented Apr 18, 2024

is there a way to make this dynamic? I'm inspired by what Armando did here:

fern/README.md

Line 79 in 8633c28

| `fernapi/fern-typescript-node-sdk` | [![Typescript Generator Version](https://img.shields.io/docker/v/fernapi/fern-typescript-node-sdk)](./generators/typescript/sdk/VERSION) | [CHANGELOG.md](./generators/typescript/sdk/CHANGELOG.md) | [cli.ts](./generators/typescript/sdk/cli/src/nodeCli.ts) |
)

@bsinghvi
Copy link
Contributor Author

@dannysheridan there would still have to be some level of manual intervention to determine which version we should mark as safe to be the default invocation version. right now, Armando's just grabs the latest, which could potentially not be release safe

@dsinghvi
Copy link
Member

is there a way to make this dynamic? I'm inspired by what Armando did here:

fern/README.md

Line 79 in 8633c28

| `fernapi/fern-typescript-node-sdk` | [![Typescript Generator Version](https://img.shields.io/docker/v/fernapi/fern-typescript-node-sdk)](./generators/typescript/sdk/VERSION) | [CHANGELOG.md](./generators/typescript/sdk/CHANGELOG.md) | [cli.ts](./generators/typescript/sdk/cli/src/nodeCli.ts) |

)

@dannysheridan there would still have to be some level of manual intervention to determine which version we should mark as safe to be the default invocation version. right now, Armando's just grabs the latest, which could potentially not be release safe

That's right -- in fact the latest TS release has some issues so have to wait to merge this

@bsinghvi
Copy link
Contributor Author

@dsinghvi this PR doesn't update it to the latest for the TypeScript SDK - are there concerns with 12.9?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants