New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: introduce oauth configs into IR, Fern def and OAS extensions #3373
base: main
Are you sure you want to change the base?
Conversation
…fern def parsers to put to this type
path: | ||
type: string | ||
docs: The path to append to the base URL to get the authorization endpoint a user is meant to visit within the browser. | ||
queryParameters: optional<list<OauthAuthorizationEndpointParameters>> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the property is named queryParameters
, should we just use http.QueryParameter
here instead of defining OauthAuthorizationEndpointParameters
?
QueryParameter:
extends: commons.Declaration
properties:
name: commons.NameAndWireValue
valueType: types.TypeReference
allowMultiple: boolean
union: | ||
authorizationCode: AuthorizationCodeOAuthScheme | ||
clientCredentials: ClientCredentialsOAuthScheme | ||
OauthAccessTokenFields: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Maybe best to standardize on either OAuth*
or Oauth
. I prefer OAuth*
, but fine with either way.
The general idea here is to allow the SDKs to generate helper methods for oauth. We're taking different paths for the different types of oauth:
authorization-endpoint