feat: add window icon #1500
Closed
feat: add window icon #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcmxcdev
reviewed
Dec 26, 2023
| @@ -219,6 +219,7 @@ const createWindow = () => { | |||
| titleBarStyle: isMac ? 'hidden' : 'default', | |||
| frame: isLinux, | |||
| backgroundColor, | |||
| icon: join(__dirname, 'build-helpers/images/icons/16x16.png'), | |||
There was a problem hiding this comment.
Can you provide a screenshot showing the difference between with icon and without?
According to the electron documentation it supposedly is optional: "On Windows it is recommended to use ICO icons to get best visual effects, you can also leave it undefined so the executable's icon will be used."
See https://www.electronjs.org/docs/latest/api/browser-window#new-browserwindowoptions > "icon"
vraravam
force-pushed
the
window-icon
branch
from
7f982c6
to
750849d
Compare
|
@laur89 - would you be able to answer the question posed in the review comment? Or can we close this PR as abandoned? |
|
Closing as abandoned |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-flight Checklist
Please ensure you've completed all of the following.
Description of Change
Adds a window icon.
Motivation and Context
Makes it easier to visually identify the Ferdium window in a tiling wm.
Checklist
pnpm prepare-code)pnpm testpassesRelease Notes